Linked Time: Conditionally remove fob deselect button #6016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rileyajones
force-pushed
the
fob-deselect-button
branch
from
edb28ca
to
32ad1b4
Compare
japie1235813
approved these changes
Nov 3, 2022
| axisDirection?: AxisDirection; | ||
| }): ComponentFixture<TestableFobComponent> { | ||
| const fixture = TestBed.createComponent(TestableFobComponent); | ||
| fixture.componentInstance.step = input.step ? input.step : 1; | ||
| fixture.componentInstance.axisDirection = input.axisDirection | ||
| ? input.axisDirection | ||
| : AxisDirection.HORIZONTAL; | ||
| if (input.allowRemoval !== undefined) { | ||
| fixture.componentInstance.allowRemoval = Boolean(input.allowRemoval); |
There was a problem hiding this comment.
why you need to cast to Boolean? Isn't the type specified in param already?
There was a problem hiding this comment.
That's a good point. Originally I was planning on just passing the input directly through but the default to true made that kinda funky.
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Nov 4, 2022
* Motivation for features / changes It does not make sense for a prospective fob to have a deselect button * Technical description of changes Add a prop to the card fob component which controls the appearance of the deselect button. * Screenshots of UI changes None * Detailed steps to verify changes work correctly (as executed by you) There should be no changes.
rileyajones
added a commit
that referenced
this pull request
Nov 14, 2022
Blocked by #6006 and #6016 ## Motivation for features / changes We believe the many check boxes in the settings panel to not be very discoverable and a generally poor user experience.  To remedy this we would like to shown a "Prospective Fob" when the user hovers over the scalar card chart. When the user clicks on this "prospective fob", a fob will be placed at the corresponding location and step selection / range selection will be enabled as appropriate. ## Technical description of changes ## Screenshots of UI changes Step Selection Disabled  Step Selection Enabled  ## Detailed steps to verify changes work correctly (as executed by you) ### Enabling Step Selection 1) Start tensorboard 2) Navigate to http://localhost:6006?enableDataTable=true&allowRangeSelection=true&enableProspectiveFob=true 3) Hover over the X Axis of a scalar card chart 4) Assert a prospective fob is shown and has no deselect button 5) Click on the prospective fob 6) Assert step selection is enabled and the data table is shown ### Enabling Range Selection With Step Selection Enabled 1) Hovering the X Axis of the scalar card 2) Assert a prospective fob is shown 3) Click the prospective fob 4) Assert range selection is now enabled 5) Continue hovering the X Axis of the scalar card 6) Assert no prospective fob is shown 7) Remove a fob 8) Hover the X Axis of the scalar card 9) Assert a prospective fob is shown * Alternate designs / implementations considered
qihach64
pushed a commit
to qihach64/tensorboard
that referenced
this pull request
Dec 19, 2022
* Motivation for features / changes It does not make sense for a prospective fob to have a deselect button * Technical description of changes Add a prop to the card fob component which controls the appearance of the deselect button. * Screenshots of UI changes None * Detailed steps to verify changes work correctly (as executed by you) There should be no changes.
qihach64
pushed a commit
to qihach64/tensorboard
that referenced
this pull request
Dec 19, 2022
Blocked by tensorflow#6006 and tensorflow#6016 ## Motivation for features / changes We believe the many check boxes in the settings panel to not be very discoverable and a generally poor user experience.  To remedy this we would like to shown a "Prospective Fob" when the user hovers over the scalar card chart. When the user clicks on this "prospective fob", a fob will be placed at the corresponding location and step selection / range selection will be enabled as appropriate. ## Technical description of changes ## Screenshots of UI changes Step Selection Disabled  Step Selection Enabled  ## Detailed steps to verify changes work correctly (as executed by you) ### Enabling Step Selection 1) Start tensorboard 2) Navigate to http://localhost:6006?enableDataTable=true&allowRangeSelection=true&enableProspectiveFob=true 3) Hover over the X Axis of a scalar card chart 4) Assert a prospective fob is shown and has no deselect button 5) Click on the prospective fob 6) Assert step selection is enabled and the data table is shown ### Enabling Range Selection With Step Selection Enabled 1) Hovering the X Axis of the scalar card 2) Assert a prospective fob is shown 3) Click the prospective fob 4) Assert range selection is now enabled 5) Continue hovering the X Axis of the scalar card 6) Assert no prospective fob is shown 7) Remove a fob 8) Hover the X Axis of the scalar card 9) Assert a prospective fob is shown * Alternate designs / implementations considered
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
* Motivation for features / changes It does not make sense for a prospective fob to have a deselect button * Technical description of changes Add a prop to the card fob component which controls the appearance of the deselect button. * Screenshots of UI changes None * Detailed steps to verify changes work correctly (as executed by you) There should be no changes.
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
Blocked by tensorflow#6006 and tensorflow#6016 ## Motivation for features / changes We believe the many check boxes in the settings panel to not be very discoverable and a generally poor user experience.  To remedy this we would like to shown a "Prospective Fob" when the user hovers over the scalar card chart. When the user clicks on this "prospective fob", a fob will be placed at the corresponding location and step selection / range selection will be enabled as appropriate. ## Technical description of changes ## Screenshots of UI changes Step Selection Disabled  Step Selection Enabled  ## Detailed steps to verify changes work correctly (as executed by you) ### Enabling Step Selection 1) Start tensorboard 2) Navigate to http://localhost:6006?enableDataTable=true&allowRangeSelection=true&enableProspectiveFob=true 3) Hover over the X Axis of a scalar card chart 4) Assert a prospective fob is shown and has no deselect button 5) Click on the prospective fob 6) Assert step selection is enabled and the data table is shown ### Enabling Range Selection With Step Selection Enabled 1) Hovering the X Axis of the scalar card 2) Assert a prospective fob is shown 3) Click the prospective fob 4) Assert range selection is now enabled 5) Continue hovering the X Axis of the scalar card 6) Assert no prospective fob is shown 7) Remove a fob 8) Hover the X Axis of the scalar card 9) Assert a prospective fob is shown * Alternate designs / implementations considered
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
* Motivation for features / changes It does not make sense for a prospective fob to have a deselect button * Technical description of changes Add a prop to the card fob component which controls the appearance of the deselect button. * Screenshots of UI changes None * Detailed steps to verify changes work correctly (as executed by you) There should be no changes.
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
Blocked by tensorflow#6006 and tensorflow#6016 ## Motivation for features / changes We believe the many check boxes in the settings panel to not be very discoverable and a generally poor user experience.  To remedy this we would like to shown a "Prospective Fob" when the user hovers over the scalar card chart. When the user clicks on this "prospective fob", a fob will be placed at the corresponding location and step selection / range selection will be enabled as appropriate. ## Technical description of changes ## Screenshots of UI changes Step Selection Disabled  Step Selection Enabled  ## Detailed steps to verify changes work correctly (as executed by you) ### Enabling Step Selection 1) Start tensorboard 2) Navigate to http://localhost:6006?enableDataTable=true&allowRangeSelection=true&enableProspectiveFob=true 3) Hover over the X Axis of a scalar card chart 4) Assert a prospective fob is shown and has no deselect button 5) Click on the prospective fob 6) Assert step selection is enabled and the data table is shown ### Enabling Range Selection With Step Selection Enabled 1) Hovering the X Axis of the scalar card 2) Assert a prospective fob is shown 3) Click the prospective fob 4) Assert range selection is now enabled 5) Continue hovering the X Axis of the scalar card 6) Assert no prospective fob is shown 7) Remove a fob 8) Hover the X Axis of the scalar card 9) Assert a prospective fob is shown * Alternate designs / implementations considered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
It does not make sense for a prospective fob to have a deselect button
Technical description of changes
Add a prop to the card fob component which controls the appearance of the deselect button.
Screenshots of UI changes
None
Detailed steps to verify changes work correctly (as executed by you)
There should be no changes.