Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TensorBoard 2.11.2 #6143

Merged
merged 3 commits into from
Jan 13, 2023
Merged

TensorBoard 2.11.2 #6143

merged 3 commits into from
Jan 13, 2023

Conversation

arcra
Copy link
Member

@arcra arcra commented Jan 13, 2023

@arcra
Fixes bug with the config passed to the "limited-input device" auth f…
a7f1f59 
…low (tensorflow#6142)

* Motivation for features / changes
  There's a bug in the limited-input device auth flow.

The tests did not catch this issue because the config is read from a
JSON string, and the test was using an "already parsed" config
(dictionary), with a different structure from the json downloaded from
our GCP project.

* Technical description of changes
Unwraps the parsed client_config from the "installed" layer, and updates
test with a "realistic" configuration (which uses this structure).

* Screenshots of UI changes
N/A

* Detailed steps to verify changes work correctly (as executed by you)
Ran both auth flows manually (with and without browser), and updated
tests.

* Alternate designs / implementations considered
N/A
@arcra
Add 2.11.2 relnotes to RELEASE.md
ef7180a
@arcra
TensorBoard 2.11.2
e3adaa2
@arcra arcra requested a review from nfelt January 13, 2023 19:57
@arcra arcra merged commit 76d9938 into tensorflow:2.11 Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfelt nfelt nfelt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arcra @nfelt