Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedding Projector: show error on task failure #6326

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

alicialics
Copy link
Contributor

@alicialics alicialics commented Apr 15, 2023

Motivation for features / changes

When an error occurs user gets stuck with a modal that can't be dismissed.

Technical description of changes

show a proper error modal that can be dismissed.

Screenshots of UI changes

image

Detailed steps to verify changes work correctly (as executed by you)

  1. Open Word2Vec 10K
  2. open t-SNE
  3. open UMAP
  4. see this error

Alternate designs / implementations considered

@JamesHollyer JamesHollyer self-requested a review June 12, 2023 21:50
@rileyajones rileyajones merged commit c674933 into tensorflow:master Jun 22, 2023
14 checks passed
@alicialics alicialics deleted the fix_error_modal branch June 27, 2023 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants