Embedding Projector: fix bookmark projection state #6328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alicialics
force-pushed
the
fix_bookmark_proj
branch
2 times, most recently
from
7bf028f
to
6436b3b
Compare
alicialics
force-pushed
the
fix_bookmark_proj
branch
from
6436b3b
to
f3d5a47
Compare
rileyajones
approved these changes
Apr 18, 2023
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
## Motivation for features / changes When a bookmark state of loaded, it will contain data on a certain set of projections for some of points (B). The app also has a different (current) state (A) in terms of which points are projected. We should completely replace the App state (A) with the bookmark state B. ## Technical description of changes store/replace shuffledDataIndices for bookmarks wipe out existing projections in app state ## Screenshots of UI changes N/A ## Detailed steps to verify changes work correctly (as executed by you) 1. Export a bookmark that has a UMAP state 2. Refresh app, open UMAP panel and load in the previous state. 3. Verify only one set of 5k points are shown (as opposed to 10k points) 4. Refresh app, load previous UMAP state and adjust parameters to a new UMAP calc is performed 5. Verify only one set of 5k points are shown (as opposed to 10k points) ## Alternate designs / implementations considered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
When a bookmark state of loaded, it will contain data on a certain set of projections for some of points (B).
The app also has a different (current) state (A) in terms of which points are projected.
We should completely replace the App state (A) with the bookmark state B.
Technical description of changes
store/replace shuffledDataIndices for bookmarks
wipe out existing projections in app state
Screenshots of UI changes
N/A
Detailed steps to verify changes work correctly (as executed by you)
Alternate designs / implementations considered