Suggested Cards: Create data source for persisting card interactions to localStorage #6439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rileyajones
force-pushed
the
card-interactions-datasource
branch
from
fc6494d
to
e15cd4d
Compare
rileyajones
force-pushed
the
card-interactions-datasource
branch
from
e15cd4d
to
594e291
Compare
JamesHollyer
approved these changes
Aug 30, 2023
tensorboard/webapp/metrics/data_source/card_interactions_data_source_module.ts
Outdated
Show resolved
Hide resolved
| @@ -453,6 +453,16 @@ const {initialState, reducers: namespaceContextedReducer} = | |||
| settings: METRICS_SETTINGS_DEFAULT, | |||
| settingOverrides: {}, | |||
| visibleCardMap: new Map<ElementId, CardId>(), | |||
| previousCardInteractions: { | |||
There was a problem hiding this comment.
This is fine. However, I would prefer to add this state into the reducer when it is starting to be used.
There was a problem hiding this comment.
I would need to define the state property as optional in order to make typescript happy and I would rather not do that. It's also inconsistent with the way we define other defaults.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
We are working on a feature to suggest cards to users at the top of the timeseries dashboard. Suggestions are generated based on previous interactions with TensorBoard. In order to determine what those previous interactions were we are storing them to localStorage.
See #6437 for more information.
Googlers see go/tb-suggested-cards