Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.15.1 patch release #6674

Merged
merged 8 commits into from Nov 2, 2023
Merged

2.15.1 patch release #6674

merged 8 commits into from Nov 2, 2023

Conversation

bmd3k
Copy link
Contributor

@bmd3k bmd3k commented Nov 2, 2023

This is a patch release of TensorBoard with the following cherry-picks from master:

I will rebase and merge the commits.

JamesHollyer and others added 8 commits November 2, 2023 07:21
…ow#6658)

## Motivation for features / changes
Issue number 5 in tensorflow#6651. It is also just a better experience to keep
previously loaded data intact while fetching new data.

## Technical description of changes
In order to put the spinner below the headers I added the spinner to the
data-table. It seems like a general feature that should be in that
widget anyway.

## Screenshots of UI changes (or N/A)
![2023-10-20_15-13-34
(1)](https://github.com/tensorflow/tensorboard/assets/8672809/23bfa0ed-077c-45fb-9df5-a0c3db1db67d)
## Motivation for features / changes
The new mat-button uses different colors in it's styling. This caused a
readability problem with our Next and Prev buttons when enabled. This
fixes the buttons to be readable and look nice. We decided the
transparent background looked nice in dark mode but not in light mode.

This was brought to our attention in tensorflow#6651.

## Screenshots of UI changes (or N/A)
Before:
<img width="905" alt="Screenshot 2023-10-20 at 11 22 09 AM"
src="https://github.com/tensorflow/tensorboard/assets/8672809/ffad969c-4fa0-4f45-af80-0975a5ad2756">
<img width="897" alt="Screenshot 2023-10-20 at 11 22 17 AM"
src="https://github.com/tensorflow/tensorboard/assets/8672809/5fc01f59-7e6c-407d-929b-aac6bdcf0ac6">

After:
<img width="868" alt="Screenshot 2023-10-20 at 11 00 38 AM"
src="https://github.com/tensorflow/tensorboard/assets/8672809/e8000574-910e-4fef-bb44-26b4faeb5966">
<img width="887" alt="Screenshot 2023-10-20 at 11 13 09 AM"
src="https://github.com/tensorflow/tensorboard/assets/8672809/18b821d0-1942-43cd-a501-5d5b7549a8a6">

## Alternate designs / implementations considered (or N/A)
Also considered having a transparent background in light mode.
Remove the experimental API that generates pandas data frames from
TensorBoard.dev data. We are turning down TensorBoard.dev.
…ensorflow#6638)

In this step of the TensorBoard.dev turndown, we remove the ability to
upload via the `tensorboard dev upload` command.

Instead, when a user invokes `tensorboard dev upload`, we print the
following message, which is similar to the message we currently return
in the server info from TensorBoard.dev backends:

```
****************************************************************
****************************************************************
****************************************************************

Uploading TensorBoard logs to https://tensorboard.dev/ is no longer
supported.

TensorBoard.dev is shutting down.

Please export your experiments by Dec 31, 2023.

See the FAQ at https://tensorboard.dev.

****************************************************************
****************************************************************
****************************************************************
```

We also remove a bunch of upload-specific code.

Testing:
I tested the changes by trying some version of the following commands:
`bazel run tensorboard -- dev auth revoke`
`bazel run tensorboard -- dev upload`
`bazel run tensorboard -- dev list`
`bazel run tensorboard -- dev update-metadata`
`bazel run tensorboard -- dev delete`
`bazel run tensorboard -- dev export`
## Motivation for features / changes
We have been treating all run names as strings even though some run
names are (serialized) numbers and some begin with numbers. This means
that sorting worked pretty unintuitively.

Note: I've also changed the behavior around sorting `undefined` values.
When sorting descending they should now appear at the top of the list.
This was a recent change but it wasn't clear it was intentional and I
found it made the code more complex.

tensorflow#6651

Internal users see [b/278671226](http://b/278671226)

## Screenshots of UI changes (or N/A)

Before:

![image](https://github.com/tensorflow/tensorboard/assets/78179109/5f805c37-283d-4f55-b1bf-3dfa4d9ea1da)

After:

![image](https://github.com/tensorflow/tensorboard/assets/78179109/0d740b6e-2ed5-4762-aec0-22400eeb152d)


![image](https://github.com/tensorflow/tensorboard/assets/78179109/5283bade-b4da-401d-9893-932d9fb9d378)
@bmd3k bmd3k merged commit 8343cad into tensorflow:2.15 Nov 2, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants