Bug Fix: Fix color picker regression #6682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmd3k
reviewed
Nov 11, 2023
| @@ -127,4 +127,10 @@ export class RunsDataTable { | |||
| const input = event.target! as HTMLInputElement; | |||
| this.onRegexFilterChange.emit(input.value); | |||
| } | |||
|
|
|||
| trackByRuns(index: number, data: TableData) { | |||
There was a problem hiding this comment.
Can you document what/why you're doing this? And can you add a test?
There was a problem hiding this comment.
I'll add a comment explaining how trackBy guards rerenders of items within an ngFor.
This is going to be very hard to test because it involves tracking whether a non angular component is rerendered.
I can add a test ensuring this get called, but since it's a framework feature I'm not sure that is worth doing.
There was a problem hiding this comment.
Maybe just a test for the logic in this function. it('returns the data object without the color attribute');
JamesHollyer
approved these changes
Nov 13, 2023
rileyajones
force-pushed
the
color-picker
branch
from
57e3152
to
8443dd3
Compare
rileyajones
force-pushed
the
color-picker
branch
from
8443dd3
to
5b49963
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
There was a regression associated with the new runs table which meant that changing the color of a run immediately closed the color picker.
Technical description of changes
Previously the runs table did not have a dependency on the metrics state. Now that it does, changing the color of a run leads to a state change which then in turn rerenders the row and thus closed the color picker.
The state dependency is important so that cannot be undone, however, we don't actually need to re render the rows when the color changes so I've update the render logic to ignore the
colorattribute (I know it's a little hacky).Screenshots of UI changes (or N/A)
Before:
After - With Paint Flashing
After - Without Paint Flashing
Detailed steps to verify changes work correctly (as executed by you)
Alternate designs / implementations considered (or N/A)