Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Hparams keras test to be compatible internally #6773

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

bmd3k
Copy link
Contributor

@bmd3k bmd3k commented Mar 4, 2024

#6759 modified _keras_test.py to work with Keras 3 but it did not import correctly into the internal repository. It was therefore reverted in #6767.

This changes the test to work both in the oss and internal repos.

Googlers, see cl/612511563 for sample import results.

@bmd3k bmd3k requested a review from rileyajones March 4, 2024 19:59
Copy link
Contributor

@rileyajones rileyajones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring this out Brian!

@bmd3k bmd3k merged commit bdfe6a7 into tensorflow:master Mar 4, 2024
13 checks passed
AnuarTB pushed a commit to AnuarTB/tensorboard that referenced this pull request May 3, 2024
tensorflow#6759 modified _keras_test.py to work with Keras 3 but it did not import
correctly into the internal repository. It was therefore reverted in
tensorflow#6767.

This changes the test to work both in the oss and internal repos.

Googlers, see cl/612511563 for sample import results.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants