Handle undefiled unknown query params gracefully #6793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmd3k
approved these changes
Mar 18, 2024
AnuarTB
pushed a commit
to AnuarTB/tensorboard
that referenced
this pull request
May 3, 2024
## Motivation for features / changes The internal deeplink provider doesn't know about `unknownQueryParams` yet and as such dispatches `stateRehydratedFromUrl` without defining a value for `unknownQueryParams`. This leads to a null pointer being thrown when loading in from the experiment list view. By defining a default value this null state can never occur.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
The internal deeplink provider doesn't know about
unknownQueryParamsyet and as such dispatchesstateRehydratedFromUrlwithout defining a value forunknownQueryParams. This leads to a null pointer being thrown when loading in from the experiment list view. By defining a default value this null state can never occur.