Fixes MatIconTestingModule import #6797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoonji
commented
Mar 18, 2024
| @@ -13,8 +13,8 @@ See the License for the specific language governing permissions and | |||
| limitations under the License. | |||
| ==============================================================================*/ | |||
|
|
|||
| import {ComponentFixture, TestBed} from '@angular/core/testing'; | |||
There was a problem hiding this comment.
ComponentFixture is unused
bmd3k
approved these changes
Mar 18, 2024
Closed
AnuarTB
pushed a commit
to AnuarTB/tensorboard
that referenced
this pull request
May 3, 2024
## Motivation for features / changes Importing MatIconTestingModule from `@angular/material/icon/testing` will break 1p sync. Changing this to import from `webapp/testing/mat_icon_module.ts` instead, in accordance with previous usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
Importing MatIconTestingModule from
@angular/material/icon/testingwill break 1p sync. Changing this to import fromwebapp/testing/mat_icon_module.tsinstead, in accordance with previous usage.