Remove strict_deps = False and update dependencies in some sass rules.
#6818
Conversation
Googlers, see cl/617525193.
|
Updated with the appropriate angular material dependency reference. PTAL. |
tensorboard/BUILD
Outdated
| load("@rules_python//python:py_binary.bzl", "py_binary") | ||
| load("@rules_python//python:py_library.bzl", "py_library") | ||
| load("@rules_python//python:py_test.bzl", "py_test") | ||
| load("//tensorboard/defs:py_repl.bzl", "py_repl") |
There was a problem hiding this comment.
This (and other files) were not in the original CL. Is this from your buildifier run? If so, which version of buildifier are you using? CI uses 3.0.0. Looks like this is 3.0.0 compatible, though (but so was the old order).
There was a problem hiding this comment.
Ah, I just ran the command, hoping that my machine would find it, but it looks like it used an internal, more recent version.
I used the download_buildifier.sh script from our repo, just like the CI workflow does, to get that same version, reverted the previous commit, and ran that command from the CI workflow, without the --mode=check flag.
For future reference, is there an easier/better way to accomplish this?
There was a problem hiding this comment.
I don't know if there is an easier/better way to accomplish. I basically did/do the same as you describe.
This reverts commit 6c53c98.
…es. (tensorflow#6818) Googlers see cl/617525193. Also ran `buildifier` to format BUILD files. (Linter step was failing from CI run for this change).
Googlers see cl/617525193.
Also ran
buildifierto format BUILD files. (Linter step was failing from CI run for this change).