Fix the issue with coloring when trying to add more experiments. #6861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnuarTB
force-pushed
the
fix_color_by_regexp
branch
from
0947e34
to
388ddf5
Compare
There was a problem when user tried to 1) enable coloring by experiment name, 2) trying to add more experiments. It stemmed from not implementing the serialization and deserialization of REGEX_BY_EXP in the query pararms of the route. To followup the tensorflow#6846 and tensorflow#6847 I have added the 'regex_exp:' as a query parameter for coloring by experiment name.
AnuarTB
force-pushed
the
fix_color_by_regexp
branch
from
388ddf5
to
6268a35
Compare
hoonji
approved these changes
Jun 4, 2024
arcra
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem when user tried to 1) enable coloring by experiment name, 2) trying to add more experiments. It stemmed from not implementing the serialization and deserialization of REGEX_BY_EXP in the query pararms of the route. To followup the #6846 and #6847 I have added the 'regex_exp:' as a query parameter for coloring by experiment name.
Motivation for features / changes
To fix the issue with the new feature.
Technical description of changes
Added
regex_exp:query param for serialization and deserialization ofREGEX_BY_EXPGroupBy. It ensures that whenever user share the URL the filter will remain in place.Screenshots of UI changes (or N/A)
Detailed steps to verify changes work correctly (as executed by you)
Add more experimentsin the top panel.Alternate designs / implementations considered (or N/A)