[XLA] Add a 'custom' fusion op type #10319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
@eliben are you reviewing this? |
eliben
suggested changes
Jun 14, 2017
| @@ -62,6 +62,8 @@ class HloInstruction { | |||
| kTransposeDot, // Fused into a dot with transposed operands. | |||
| kConvBackwardFilter, // Fused into a backward filter convolution. | |||
| kConvBackwardInput, // Fused into a backward input convolution. | |||
|
|
|||
| kCustom, // Custom fusions. | |||
There was a problem hiding this comment.
Can you elaborate a bit more in this comment, mentioning backend-specific fustions
eliben
approved these changes
Jun 15, 2017
|
Jenkins, test this please. |
martinwicke
added
awaiting testing (then merge)
and removed
awaiting review
|
cool - thanks |
|
@martinwicke Hi there. Could this be merged now? Cheers |
allenlavoie
pushed a commit
to allenlavoie/tensorflow
that referenced
this pull request
Jul 15, 2017
* Add a 'custom' fusion op type * Improve the description of the fusion type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows backends that may have fusions that are not included in the main enumeration.