Make TensorFlow build with wrapper-free MSVC CROSSTOOL #11114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins, test this please |
|
@jart WDYT? |
|
@jhseu are we ok to use a non-released protobuf? |
|
Jenkins, test this please. |
|
Hmm.. Looks like CI doesn't like my change on protobuf... |
|
Generally it's fine to build with a non-released protobuf, but since it was reverted, seems fine to me. |
gunan
approved these changes
Jun 30, 2017
|
@gunan Can you update Bazel to 0.5.2 on Windows slaves? |
|
All machines should now be upgraded. |
|
@gunan Great! http://ci.tensorflow.org/job/tf-master-win-bzl/1213/console is green again! |
allenlavoie
pushed a commit
to allenlavoie/tensorflow
that referenced
this pull request
Jul 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the latest Bazel release (0.5.2), we can now build C++ code on Windows without the python wrapper scripts! This gives faster and more reliable build, but gcc flags in BUILD file won't be translated.
This change removes gcc flags(mostly warning flags) that will cause an error if passed to cl.exe.
The protobuf change is to get protocolbuffers/protobuf@0b059a3, not sure if there is a requirement to use release version of protobuf.
@gunan