[XLA] Replace TEST_F with XLA_TEST_F to allow for disabling #12520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
jpienaar
approved these changes
Aug 23, 2017
|
Jenkins, test this please |
copybara-service bot
pushed a commit
that referenced
this pull request
May 16, 2024
Imported from GitHub PR openxla/xla#12520 It's more granular than the existing --xla_gpu_deterministic_ops because it allows doing an autotuning compilation with non-deterministic ops disabled. --xla_gpu_deterministic_ops is a superset of --xla_gpu_exclude_nondeterministic_ops, so --xla_gpu_deterministic_ops=true will be setting --xla_gpu_exclude_nondeterministic_ops=true too. Copybara import of the project: -- f47f18016777468fe274bea00945d5209a2cdb57 by Ilia Sergachev <isergachev@nvidia.com>: [GPU] Add new flag xla_gpu_exclude_nondeterministic_ops. Merging this change closes #12520 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#12520 from openxla:new_determinism_flag f47f18016777468fe274bea00945d5209a2cdb57 PiperOrigin-RevId: 634336994
copybara-service bot
pushed a commit
that referenced
this pull request
May 17, 2024
Imported from GitHub PR openxla/xla#12520 It's more granular than the existing --xla_gpu_deterministic_ops because it allows doing an autotuning compilation with non-deterministic ops disabled. --xla_gpu_deterministic_ops is a superset of --xla_gpu_exclude_nondeterministic_ops, so --xla_gpu_deterministic_ops=true will be setting --xla_gpu_exclude_nondeterministic_ops=true too. Copybara import of the project: -- 4e2837457dc426154bf80f321c001c916a7d3677 by Ilia Sergachev <isergachev@nvidia.com>: [GPU] Add new flag xla_gpu_exclude_nondeterministic_ops. Merging this change closes #12520 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#12520 from openxla:new_determinism_flag 4e2837457dc426154bf80f321c001c916a7d3677 PiperOrigin-RevId: 634336994
copybara-service bot
pushed a commit
that referenced
this pull request
May 17, 2024
Imported from GitHub PR openxla/xla#12520 It's more granular than the existing --xla_gpu_deterministic_ops because it allows doing an autotuning compilation with non-deterministic ops disabled. --xla_gpu_deterministic_ops is a superset of --xla_gpu_exclude_nondeterministic_ops, so --xla_gpu_deterministic_ops=true will be setting --xla_gpu_exclude_nondeterministic_ops=true too. Copybara import of the project: -- 4e2837457dc426154bf80f321c001c916a7d3677 by Ilia Sergachev <isergachev@nvidia.com>: [GPU] Add new flag xla_gpu_exclude_nondeterministic_ops. Merging this change closes #12520 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#12520 from openxla:new_determinism_flag 4e2837457dc426154bf80f321c001c916a7d3677 PiperOrigin-RevId: 634336994
copybara-service bot
pushed a commit
that referenced
this pull request
May 17, 2024
Imported from GitHub PR openxla/xla#12520 It's more granular than the existing --xla_gpu_deterministic_ops because it allows doing an autotuning compilation with non-deterministic ops disabled. --xla_gpu_deterministic_ops is a superset of --xla_gpu_exclude_nondeterministic_ops, so --xla_gpu_deterministic_ops=true will be setting --xla_gpu_exclude_nondeterministic_ops=true too. Copybara import of the project: -- 68b555ff66f299423a8de6aef595cf38f621976f by Ilia Sergachev <isergachev@nvidia.com>: [GPU] Add new flag xla_gpu_exclude_nondeterministic_ops. Merging this change closes #12520 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#12520 from openxla:new_determinism_flag 68b555ff66f299423a8de6aef595cf38f621976f PiperOrigin-RevId: 634336994
copybara-service bot
pushed a commit
that referenced
this pull request
May 17, 2024
Imported from GitHub PR openxla/xla#12520 It's more granular than the existing --xla_gpu_deterministic_ops because it allows doing an autotuning compilation with non-deterministic ops disabled. --xla_gpu_deterministic_ops is a superset of --xla_gpu_exclude_nondeterministic_ops, so --xla_gpu_deterministic_ops=true will be setting --xla_gpu_exclude_nondeterministic_ops=true too. Copybara import of the project: -- 4e2837457dc426154bf80f321c001c916a7d3677 by Ilia Sergachev <isergachev@nvidia.com>: [GPU] Add new flag xla_gpu_exclude_nondeterministic_ops. Merging this change closes #12520 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#12520 from openxla:new_determinism_flag 4e2837457dc426154bf80f321c001c916a7d3677 PiperOrigin-RevId: 634721436
copybara-service bot
pushed a commit
that referenced
this pull request
May 17, 2024
Imported from GitHub PR openxla/xla#12520 It's more granular than the existing --xla_gpu_deterministic_ops because it allows doing an autotuning compilation with non-deterministic ops disabled. --xla_gpu_deterministic_ops is a superset of --xla_gpu_exclude_nondeterministic_ops, so --xla_gpu_deterministic_ops=true will be setting --xla_gpu_exclude_nondeterministic_ops=true too. Copybara import of the project: -- 68b555ff66f299423a8de6aef595cf38f621976f by Ilia Sergachev <isergachev@nvidia.com>: [GPU] Add new flag xla_gpu_exclude_nondeterministic_ops. Merging this change closes #12520 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#12520 from openxla:new_determinism_flag 68b555ff66f299423a8de6aef595cf38f621976f PiperOrigin-RevId: 634336994
copybara-service bot
pushed a commit
that referenced
this pull request
May 17, 2024
Imported from GitHub PR openxla/xla#12520 It's more granular than the existing --xla_gpu_deterministic_ops because it allows doing an autotuning compilation with non-deterministic ops disabled. --xla_gpu_deterministic_ops is a superset of --xla_gpu_exclude_nondeterministic_ops, so --xla_gpu_deterministic_ops=true will be setting --xla_gpu_exclude_nondeterministic_ops=true too. Copybara import of the project: -- 68b555ff66f299423a8de6aef595cf38f621976f by Ilia Sergachev <isergachev@nvidia.com>: [GPU] Add new flag xla_gpu_exclude_nondeterministic_ops. Merging this change closes #12520 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#12520 from openxla:new_determinism_flag 68b555ff66f299423a8de6aef595cf38f621976f PiperOrigin-RevId: 634336994
copybara-service bot
pushed a commit
that referenced
this pull request
May 17, 2024
Imported from GitHub PR openxla/xla#12520 It's more granular than the existing --xla_gpu_deterministic_ops because it allows doing an autotuning compilation with non-deterministic ops disabled. --xla_gpu_deterministic_ops is a superset of --xla_gpu_exclude_nondeterministic_ops, so --xla_gpu_deterministic_ops=true will be setting --xla_gpu_exclude_nondeterministic_ops=true too. Copybara import of the project: -- 4e2837457dc426154bf80f321c001c916a7d3677 by Ilia Sergachev <isergachev@nvidia.com>: [GPU] Add new flag xla_gpu_exclude_nondeterministic_ops. Merging this change closes #12520 PiperOrigin-RevId: 634756524
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow any of the tests in the CopyTest suite to be disabled by using a disable manifest.