Fix estimator convert from Keras to export_savedmodel() #14284 #14354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xport saved_model because the model_fn provided by _create_keras_model_fn wasn't set export_outputs in the returned EstimatorSpec. Here I provide a default export_outputs with serve_default key and Predict API, and the result inside is same as predictions
[FIX]_save_first_checkpoint call saver.save with only a path and without filename, that make the ckpt saved with name like `{model_dir}/.meta` and `{model_dir}/.index`, which can not be found by latest_checkpoint("{model_dir}"). As state by save method of Saver, save_path should be a path to the checkpoint name. So to fix this, I change the name to `{model_dir}/keras_model.ckpt`
|
Can one of the admins verify this patch? |
yifeif
reviewed
Nov 18, 2017
| @@ -33,6 +35,9 @@ | |||
| from tensorflow.python.platform import tf_logging as logging | |||
| from tensorflow.python.training import saver as saver_lib | |||
| from tensorflow.python.training import training_util | |||
| from tensorflow.python.saved_model import signature_constants | |||
There was a problem hiding this comment.
Add new dependency to tensorflow/python/keras/BUILD.
|
Thanks @yifeif for the review. The PR has been updated with review comments addressed. Please take a look. |
sb2nov
added
awaiting review
yifeif
approved these changes
Nov 30, 2017
|
Thanks @yjmade! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #14284
[FIX]the estimator generate by tf.keras.model_to_estimator() cannot export saved_model because the model_fn provided by _create_keras_model_fn wasn't set export_outputs in the returned EstimatorSpec. Here I provide a default export_outputs with serve_default key and Predict API, and the result inside is same as predictions
[FIX]_save_first_checkpoint call saver.save with only a path and without filename, that make the saved ckpt files with name like
{model_dir}/.metaand{model_dir}/.index, which is not be able to found by latest_checkpoint("{model_dir}"). As state by Saver.save(), save_path should be a path to the checkpoint name. So to fix this, I change the name to{model_dir}/keras_model.ckpt