Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update layers pull request #14785

Merged
merged 8 commits into from Dec 21, 2017
Merged

Update layers pull request #14785

merged 8 commits into from Dec 21, 2017

Conversation

shreyneil
Copy link
Contributor

@shreyneil shreyneil commented Nov 22, 2017

I have created a new pull request by updating the unit test cases with reference to my previous pull request
#13829 .
I have already updated layers.py initially by checking for beta in the if condition.
The initial pull request was raised in accordance with the issue
#11673 .

Please verify and get back.

The Changes have been made as suggested in my previous pull request.
tensorflow#13829

The unit test case has been updated along with the update in layers.py with reference to the issue tensorflow#11673. 
Please verify and get back.
@tensorflow-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

Updated layers.py
@shreyneil
Copy link
Contributor Author

Please verify and get back.

@shreyneil shreyneil changed the title Update layers_test Update layers pull request Nov 29, 2017
@shreyneil shreyneil closed this Nov 29, 2017
@shreyneil shreyneil reopened this Nov 29, 2017
@tensorflow-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@drpngx drpngx requested a review from vrv December 4, 2017 03:37
@drpngx drpngx added the awaiting review Pull request awaiting review label Dec 4, 2017
@vrv
Copy link

vrv commented Dec 4, 2017

@tensorflow-jenkins test this please

@vrv vrv added the kokoro:force-run Tests on submitted change label Dec 4, 2017
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 4, 2017
@vrv vrv added the kokoro:force-run Tests on submitted change label Dec 4, 2017
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 4, 2017
@shreyneil
Copy link
Contributor Author

it would be great if you could merge this PR.

@yifeif
Copy link
Contributor

yifeif commented Dec 20, 2017

@shreyneil do you mind fixing the test?
NameError: global name 'dtype' is not defined

@yifeif yifeif added stat:awaiting response Status - Awaiting response from author awaiting testing (then merge) and removed awaiting review Pull request awaiting review labels Dec 20, 2017
Done with the necessary change , please verify and get back.
@shreyneil
Copy link
Contributor Author

Made the necessary changes, please verify.

@yifeif
Copy link
Contributor

yifeif commented Dec 21, 2017

Thanks @shreyneil! @tensorflow-jenkins test this please.

@yifeif yifeif added kokoro:force-run Tests on submitted change and removed stat:awaiting response Status - Awaiting response from author labels Dec 21, 2017
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 21, 2017
@shreyneil
Copy link
Contributor Author

shreyneil commented Dec 21, 2017

@yifeif It would be great if you could merge this PR.

@yifeif yifeif merged commit 97a4c22 into tensorflow:master Dec 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants