Fix problem with camera on Android TV #15163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
reformat and add comment
andrewharp
approved these changes
Dec 7, 2017
|
@tensorflow-jenkins Test this, please. |
|
Merging as the failures have no dependency on the Android demo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a scenario of using a usb external camera, we should use Camera API 2 according to the definition:
Camera1 API is framework API that had been created to support HALv1.x
Camera2 API is a new API that is meant for HALv3.x.
However, CameraCharacteristics.INFO_SUPPORTED_HARDWARE_LEVEL_FULL) should return false as USB camera doesn' support all the necessary capabilities.
https://developer.android.com/reference/android/hardware/camera2/CameraMetadata.html#INFO_SUPPORTED_HARDWARE_LEVEL_FULL
This is a work around to use facing == CameraCharacteristics.LENS_FACING_EXTERNAL to detect usb external camera and use Camera2 API instead.