Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XLA] Define TF_COMPILE_LIBRARY for two libraries #15749

Merged
merged 1 commit into from
Jan 1, 2018
Merged

[XLA] Define TF_COMPILE_LIBRARY for two libraries #15749

merged 1 commit into from
Jan 1, 2018

Conversation

rongjiecomputer
Copy link
Contributor

Both index_ops_kernel_argmax_float_1d.cc and index_ops_kernel_argmax_float_2d.cc use TF_EXPORT macro. We need to define TF_COMPILE_LIBRARY (comes from tf_copts) to make sure TF_EXPORT is expanded into __declspec(dllexport).

#15213

@tensorflow-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 31, 2017
@drpngx
Copy link
Contributor

drpngx commented Dec 31, 2017

Jenkins, test this please.

@drpngx drpngx merged commit a060e06 into tensorflow:master Jan 1, 2018
@rongjiecomputer rongjiecomputer deleted the tf_compile_library branch January 1, 2018 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drpngx drpngx drpngx approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rongjiecomputer @tensorflow-jenkins @drpngx @googlebot @kokoro-team