Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MKL: cifar 10 divergance fix and batchnorm unit test fix #17004

Merged
merged 2 commits into from Mar 1, 2018
Merged

MKL: cifar 10 divergance fix and batchnorm unit test fix #17004

merged 2 commits into from Mar 1, 2018

Conversation

gzmkl
Copy link
Contributor

@gzmkl gzmkl commented Feb 14, 2018

  1. Fix Cifar 10 diverging issue
  2. Fix BatchNorm unit test failures

@gzmkl gzmkl changed the title cifar 10 divergance fix and batchnorm unit test fix MKL: cifar 10 divergance fix and batchnorm unit test fix Feb 14, 2018
tatianashp
tatianashp requested changes Feb 28, 2018
View reviewed changes
Copy link
Member

@tatianashp tatianashp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing divergence issues and test failures! Code readability is very important to us. Could you please edit the comments to be grammatically correct? If you want to abbreviate TensorFlow please use TF not tf.

@gztf
Copy link

gztf commented Mar 1, 2018

Based on suggestion from Tatiana (tatianashp), changes have been made to fix improper comments such as replacing "tf" with "TensorFlow". The fix touches statements only - so no extra test is needed.

tatianashp
tatianashp approved these changes Mar 1, 2018
View reviewed changes
Copy link
Member

@tatianashp tatianashp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the tf abbreviation issues. I'll fix the rest after the PR goes through.

@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 1, 2018
@tatianashp tatianashp merged commit 63dd9dd into tensorflow:master Mar 1, 2018
StanislawAntol pushed a commit to StanislawAntol/tensorflow that referenced this pull request Mar 23, 2018
@tatianashp
Merge pull request tensorflow#17004 from Intel-tensorflow/relu_bn_fix2
0d662ba 
MKL: cifar 10 divergance fix and batchnorm unit test fix
@nammbash nammbash deleted the relu_bn_fix2 branch April 25, 2020 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tatianashp tatianashp tatianashp approved these changes

@rmlarsen rmlarsen Awaiting requested review from rmlarsen

Assignees

@tatianashp tatianashp

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gzmkl @gztf @tatianashp @googlebot @kokoro-team