Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ gradient for Slice #17592

Merged
merged 1 commit into from
Jun 26, 2018
Merged

C++ gradient for Slice #17592

merged 1 commit into from
Jun 26, 2018

Conversation

kbsriram
Copy link
Contributor

@kbsriram kbsriram commented Mar 9, 2018

See #9645

@frankchn frankchn requested a review from suharshs March 13, 2018 05:21
@frankchn frankchn added awaiting review Pull request awaiting review kokoro:force-run Tests on submitted change labels Mar 13, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 13, 2018
@tensorflowbutler
Copy link
Member

Nagging Assignee @suharshs: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

@tensorflowbutler
Copy link
Member

Nagging Reviewer @suharshs: It has been 14 days with no activity and the awaiting review label was assigned. Can you please take a look?

suharshs
suharshs previously approved these changes Apr 19, 2018
View reviewed changes
@suharshs suharshs removed the awaiting review Pull request awaiting review label May 4, 2018
@tensorflowbutler
Copy link
Member

Nagging Assignee @suharshs: It has been 22 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

@gunan
Copy link
Contributor

gunan commented Jun 4, 2018

@kbsriram, sorry for the delay.
Could you rebase the changes, looks like we can merge as soon as all conflict are resolved.

@kbsriram
Copy link
Contributor Author

kbsriram commented Jun 8, 2018

@gunan - no worries. I rebased (which also seems to have invalidated the lgtm; the changes should be identical however.)

@gunan gunan added kokoro:run kokoro:force-run Tests on submitted change labels Jun 9, 2018
@kokoro-team kokoro-team removed kokoro:run kokoro:force-run Tests on submitted change labels Jun 9, 2018
@gunan
Copy link
Contributor

gunan commented Jun 9, 2018

@suharshs could you take a look.

@tensorflowbutler
Copy link
Member

Nagging Assignee @suharshs: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

@gunan gunan merged commit 37c79b0 into tensorflow:master Jun 26, 2018
@wumo
Copy link

wumo commented Jul 13, 2018

I find tensorflow v1.9.0-rc2 supports SliceGrad whereas tensorflow v1.9.0 throws No gradient defined for op: Slice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suharshs suharshs suharshs approved these changes

Assignees

@suharshs suharshs

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@kbsriram @tensorflowbutler @gunan @wumo @suharshs @frankchn @googlebot @kokoro-team