Improve shape function check for tf.roll
#18611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `tf.roll` op has requirements for the shape of inputs. However, the shape of the inputs are only done at the runtime inside the kernel. This fix improve the shape function so that the check could be done early if shape is already known in the shape function. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
yongtang
force-pushed
the
04162018-roll-shape
branch
from
7c09fb6
to
4e6c516
Compare
yzhwang
approved these changes
Apr 18, 2018
| def testRollInputMustVectorHigherRaises(self): | ||
| tensor = 7 | ||
| # The input should be 1-D or higher, checked is done in kernel. |
There was a problem hiding this comment.
minor nits: just for consistency, maybe change to checked in kernel.
There was a problem hiding this comment.
@yzhwang The comment has been updated. Thanks for the review!
`checked is done in kernel.` -> `checked in kernel.` for review feedback. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tf.rollop has requirements for the shape of inputs. However, the shape of the inputs are only done at the runtime inside the kernel.This fix improve the shape function so that the check could be done early if shape is already known in the shape function.
The following validations have been added in the shape function with test cases:
inputmust be 1-D or highershiftmust be scalar or 1-D.axismust be scalar or 1-D.shiftandaxisshould be the same size.They matches validations in the kernel.
Signed-off-by: Yong Tang yong.tang.github@outlook.com