Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTEL MKL] Upgrading to MKL DNN v.14 #19364

Merged
merged 3 commits into from
May 25, 2018

Conversation

agramesh1
Copy link
Contributor

It also includes fixes to handle empty input tensors in MKLAvgPooling. MKL DNN v0.14 does more sanity checks on empty input tensors and throws "invalid parameter" exceptions.

@zheng-xq zheng-xq requested a review from andydavis1 May 21, 2018 07:27
@zheng-xq zheng-xq assigned andydavis1 and unassigned zheng-xq May 21, 2018
@andydavis1
Copy link
Contributor

@tensorflow-jenkins test this please

@tatianashp tatianashp requested a review from penpornk May 21, 2018 17:22
@zheng-xq zheng-xq added the kokoro:force-run Tests on submitted change label May 21, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 21, 2018
Copy link
Member

@penpornk penpornk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, but one check is failing.

@agramesh1
Copy link
Contributor Author

@penpornk Thanks. The failure in MacOS python2 and CC seems unrelated to this PR. Several of the other PRs - #19423 and #19429 are failing the same tests.

@tatianashp tatianashp added the kokoro:force-run Tests on submitted change label May 24, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 24, 2018
@agramesh1
Copy link
Contributor Author

@tatianashp can you check the test results? It looks like MacOS Contrib and Ubuntu Contrib are both passing (in the details link), but are showing up as failures here. Also Ubuntu Sanity is failing in pylint in an unrelated python file.

@tatianashp tatianashp added the kokoro:force-run Tests on submitted change label May 25, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 25, 2018
@tatianashp tatianashp merged commit 38926b8 into tensorflow:master May 25, 2018
@nammbash nammbash deleted the agramesh/mkl_v14_fix2 branch April 25, 2020 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants