Attempt to make sense of reasoning for loss #20220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I feel the document seems a bit weird. Adding "when" seems to make better sense of it. Open to suggestions on alternatives. Thanks
qlzh727
reviewed
Jun 22, 2018
| @@ -362,7 +362,7 @@ model's loss. This is the | |||
| that will be optimized. | |||
|
|
|||
| We can calculate the loss by calling @{tf.losses.sparse_softmax_cross_entropy}. | |||
| The value returned by this function will be lowest, approximately 0, | |||
| When the value returned by this function will be lowest, approximately 0, | |||
There was a problem hiding this comment.
How about this:
The value returned by this function will be approximately 0 at lowest, when the probability of the correct class (at index label') is near 1.0.
There was a problem hiding this comment.
That sounds better. Thanks.
Should I update the PR with it ?
MarkDaoust
approved these changes
Jun 22, 2018
| @@ -362,7 +362,7 @@ model's loss. This is the | |||
| that will be optimized. | |||
|
|
|||
| We can calculate the loss by calling @{tf.losses.sparse_softmax_cross_entropy}. | |||
| The value returned by this function will be lowest, approximately 0, | |||
| When the value returned by this function will be lowest, approximately 0, | |||
qlzh727
added
awaiting testing (then merge)
and removed
awaiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel the document seems a bit weird. Adding "when" seems to make better sense of it. Open to suggestions on alternatives.
Thanks