Patch boringssl for ppc64le #20791
Patch boringssl for ppc64le #20791
Conversation
This commit adds a patch file for the bazel BUILD file contained in the boringssl.tar.gz file. It set the necessary compile options to build boringssl on pp64le. (Basically adds linux_ppc64le everywhere linux_x86_64 is) Fixes tensorflow#20677
|
Related question , if I wanted to upstream this fix so the patch wouldn't be required for Tensorflow where would I do it? The tar.gz file that is downloaded for boringssl includes more files then what I get when cloning https://boringssl.googlesource.com/boringssl/ |
|
I found that the boringssl repo has a master-with-bazel branch that I need to work from. |
| "crypto_sources", | ||
| "crypto_sources_linux_x86_64", | ||
| "crypto_sources_mac_x86_64", | ||
| + "crypto_sources_linux_ppc64le", |
There was a problem hiding this comment.
Previously when we asked boringssl about such patches, they told us some of these may not work at all.
Can we work with them to make sure this works, and then upstream it into boringssl?
There was a problem hiding this comment.
@gunan , I got the patch merged upstream into boringssl today. I'm in the process of testing the new tar.gz update in workspace.bzl, then I'll add a commit to change this PR to just use the new boringssl version.
In booringssl PR: https://boringssl-review.googlesource.com/c/boringssl/+/29784 The bazel build file was updated to build ppc64le with the same compile options as linux_x86_64. This commit updates boringssl to reference that commit.
gunan
added
awaiting testing (then merge)
kokoro:force-run
PiperOrigin-RevId: 207673964
This commit adds a patch file for the bazel BUILD file contained in the
boringssl.tar.gz file. It set the necessary compile options to build boringssl
on pp64le. (Basically adds linux_ppc64le everywhere linux_x86_64 is)
Fixes #20677