-
Notifications
You must be signed in to change notification settings - Fork 74k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network.to_json should handle numpy.ndarray correctly #21073
Conversation
Can you review this please, @fchollet? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
I fixed the bad indentation, can anyone trigger the build again? Thanks. |
@yanboliang Done |
@caisq I fixed the bad indentation again, can you re-trigger it? Thanks. BTW, do you know how I can trigger python lint checker locally before I submit the PR? |
@yanboliang With the necessary dependencies installed, you should be able to run it with this script (from the root directory of the repo): https://github.com/tensorflow/tensorflow/blob/master/tensorflow/tools/ci_build/ci_sanity.sh |
@caisq Great. I just run that script and verified this PR can pass sanity check locally. Can you trigger this test again? I'm sorry to bother you again. Thanks. |
Nagging Assignee @caisq: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly. |
I think @fchollet has implicitly approved this PR when he applied the "awaiting test then merge" tag. I've applied the "ready to pull" tag, which should have triggered the merging process. let me try it again. |
PiperOrigin-RevId: 212332139
@caisq Thanks! |
Pick the fix at keras-team/keras#10754 to
tf.keras
.