lib / pip_package: only include licenses if option is enabled #21378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The license files were included unconditionally so the whole dependency needs to be downloaded even if disabled and not used. This puts them behind in a select() so they are only included when the feature is enabled for the build and significantly reduces the dependencies when configured without all the cloud options. Signed-off-by: Jason Zaman <jason@perfinion.com>
|
I fixed the buildifier format change from https://source.cloud.google.com/results/invocations/d989dfc3-e01c-434a-8bec-4220f8fbbfc7/log |
gunan
approved these changes
Aug 8, 2018
tensorflow-copybara
pushed a commit
that referenced
this pull request
Aug 9, 2018
PiperOrigin-RevId: 207975491
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The license files were included unconditionally so the whole dependency
needs to be downloaded even if disabled and not used. This puts them
behind in a select() so they are only included when the feature is
enabled for the build and significantly reduces the dependencies when
configured without all the cloud options.
Signed-off-by: Jason Zaman jason@perfinion.com