Support empty inputs in some maxpool kernels. (#21338) #21385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Guessing by your descriptions that you are unable to write tests for this? Is this correct? Also, the github issue you tried to link seems to be a deleted/closed issue. Is there more context for this. Thanks! |
|
I linked to the wrong issue, sorry. The issue is: #21338
There is already a test for this but the test is not functioning. See the issue threads for details. |
|
Nagging Reviewer @zheng-xq: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 97 days with no activity and the |
chsigg
approved these changes
Nov 27, 2018
chsigg
added
type:bug
tensorflow-copybara
pushed a commit
that referenced
this pull request
Nov 28, 2018
PiperOrigin-RevId: 223127735
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only partially remedies #21338. A more serious issue is that such bugs cannot be detected by the unit test framework and the cudaError will leak into other ops.
Similar issues probably exist in many other ops as well.