Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing tf.contrib.data.batch_and_drop_remainder by batch(..., drop… #21553

Merged
merged 2 commits into from
Aug 14, 2018

Conversation

yashk2810
Copy link
Member

@yashk2810 yashk2810 commented Aug 12, 2018

Replacing tf.contrib.data.batch_and_drop_remainder by batch(..., drop_remainder=True). Also checkpointing at (epoch + 1) % x while saving the model to consider the last epoch's variables.

…_remainder=True). Also checkpointing at (epoch + 1) % x while saving the model to consider the last epoch's variables.
@yashk2810
Copy link
Member Author

yashk2810 commented Aug 12, 2018

@allenlavoie @drpngx @yifeif

@drpngx drpngx requested a review from mrry August 12, 2018 16:23
@drpngx drpngx self-assigned this Aug 12, 2018
@drpngx drpngx added the kokoro:force-run Tests on submitted change label Aug 13, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 13, 2018
@yifeif yifeif added the kokoro:force-run Tests on submitted change label Aug 13, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 13, 2018
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@yashk2810
Copy link
Member Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@drpngx drpngx added the ready to pull PR ready for merge process label Aug 13, 2018
@yashk2810
Copy link
Member Author

@drpngx Do you mind pulling this in? The variables are not being restired correctly. Issues will start cropping up 😅

@tensorflow-copybara tensorflow-copybara merged commit 27208e2 into tensorflow:master Aug 14, 2018
tensorflow-copybara pushed a commit that referenced this pull request Aug 14, 2018
PiperOrigin-RevId: 208579447
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes ready to pull PR ready for merge process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants