parallel_for: use absl wrapper and add converter for SoftplusGrad #21716
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the following snippet
On the current master it fails with
This is caused by the fact that no converter is registered for the
SoftplusGrad
op, and when parallel_for sees no converter defined, it tries to fall back to a while loop, if this is allowed with a special CLI flag. The problem, though, is that it uses rawabsl
call which requires one to first explicitly parse command line arguments. To mitigate that, one should use a flags wrapper from thetensorflow.platform
, which is what I did.Also, this pull introduces a converter for
SoftplusGrad
in the same way as, say,SigmoidGrad
.