Fix MPI build failure caused by StringPiece -> absl::string_view #22084
Conversation
This fix tries to fix the MPI build failure caused by StringPiece -> absl::string_view. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
|
@jlebar have we caught these already? |
Looks to me like we have not. |
|
Updated the description to include /cc @jlebar @martinwicke |
|
Looks like you clang-formatted the whole file. That's not the right thing to do: clang-format is not a stable format, so if you clang-format the entirety of every file you touch, we're going to introduce a lot of irrelevant whitespace changes. The correct thing is to apply the diff that the clang-format test was saying to apply, or to use the Whitespace, I know... @yifeif IIRC we're now clang-formatting patches when we import them to be submitted. Does that allow us to turn off the external clang-format check, so we don't have to go through this with folks anymore? |
yongtang
force-pushed
the
09012018-mpi-StringPiece
branch
from
6802d3a
to
89979f4
Compare
…ang-format Check`
The following chanes has been applied to align with `Experimental clang-format Check` test:
```
diff --git a/tensorflow/contrib/mpi/mpi_rendezvous_mgr.cc b/tensorflow/contrib/mpi/mpi_rendezvous_mgr.cc
index e195cca..b9967fe 100644
--- a/tensorflow/contrib/mpi/mpi_rendezvous_mgr.cc
+++ b/tensorflow/contrib/mpi/mpi_rendezvous_mgr.cc
@@ -136,8 +136,8 @@ void MPIRemoteRendezvous::RecvFromRemoteAsync(
MPIRendezvousMgr* mgr =
reinterpret_cast<MPIRendezvousMgr*>(this->rendezvous_mgr_);
- mgr->QueueRequest(string(parsed.FullKey()), step_id_,
- std::move(request_call), rendezvous_call);
+ mgr->QueueRequest(string(parsed.FullKey()), step_id_, std::move(request_call),
+ rendezvous_call);
}
MPIRemoteRendezvous::~MPIRemoteRendezvous() {}
```
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
|
Thanks @jlebar. I have updated the PR and now only applied the clang-format change as is shown in |
|
So was MPI related ToString issue addressed? I still see it with the latest master pull. |
Isn't the fix you're looking for in this PR, which is still unsubmitted? |
I don't know. I guess I was hoping that my question might prod someone to submit it. Wishful thinking? |
|
@phalexo This PR addresses the issue you encounter. The PR is not merged into the master yet, but it will go into master soon. |
|
This is ready for @martinwicke to submit. |
|
@jlebar, in that case, just add the "ready to pull" label. |
|
(just did for this one) |
PiperOrigin-RevId: 214048478
|
What about r1.11 branch? Is it going to get the patch? |
This fix tries to fix the MPI build failure caused by
StringPiece->absl::string_view.This fix fixes #22376.
Signed-off-by: Yong Tang yong.tang.github@outlook.com