Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A method to improve accuracy of LazyAdam #23668

Closed
mpjlu opened this issue Nov 12, 2018 · 3 comments
Closed

A method to improve accuracy of LazyAdam #23668

mpjlu opened this issue Nov 12, 2018 · 3 comments
Assignees
@ymodak
Labels
contrib Anything that comes under contrib directory stat:awaiting response Status - Awaiting response from author type:feature Feature requests

Comments

@mpjlu
Copy link
Contributor

mpjlu commented Nov 12, 2018 •
edited

No description provided.

@ymodak ymodak self-assigned this Nov 12, 2018
@ymodak ymodak added the type:feature Feature requests label Nov 12, 2018
@mpjlu mpjlu changed the title Improve accuracy of LazyAdam A method to improve accuracy of LazyAdam Nov 20, 2018
@mpjlu mpjlu mentioned this issue Nov 20, 2018
Closed
@robieta
Copy link

robieta commented Nov 20, 2018

Thanks. Can you open a PR putting it in tf.contrib.opt, and assign it to @alextp?

@ymodak ymodak added pending merge internally stat:awaiting response Status - Awaiting response from author and removed pending merge internally labels Dec 3, 2018
@futurecam
Copy link

I met the same problem of slow adam in sparse, waiting your feature

@ymodak ymodak added pending merge internally and removed stat:awaiting response Status - Awaiting response from author labels Jan 9, 2019
@ymodak ymodak added the contrib Anything that comes under contrib directory label Mar 27, 2019
@ymodak
Copy link
Contributor

ymodak commented Mar 27, 2019 •
edited

Appreciate your patience. LazyAdam now falls under tensorflow/addons starting TF 2.X. The folks of Addons - Optimizers can be a good point of contact to add this feature. Thanks!

@ymodak ymodak added the stat:awaiting response Status - Awaiting response from author label Mar 27, 2019
@ymodak ymodak closed this as completed Mar 29, 2019
@seanpmorgan seanpmorgan mentioned this issue Jul 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ymodak ymodak

Labels
contrib Anything that comes under contrib directory stat:awaiting response Status - Awaiting response from author type:feature Feature requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@robieta @mpjlu @futurecam @ymodak