Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SparseTensor multiplication in tf.keras.layers.Dense #23872

Closed
sfujiwara opened this issue Nov 20, 2018 · 1 comment
Closed

SparseTensor multiplication in tf.keras.layers.Dense #23872

sfujiwara opened this issue Nov 20, 2018 · 1 comment
Assignees
Labels
stat:awaiting tensorflower Status - Awaiting response from tensorflower

Comments

@sfujiwara
Copy link
Contributor

sfujiwara commented Nov 20, 2018

System information

  • TensorFlow version (you are using): 1.12.0
  • Are you willing to contribute it (Yes/No): Yes

Describe the feature and the current behavior/state.
In keras.layers.Dense, tf.sparse_tensor_dense_matmul is called for SparseTensor as this.
But in tf.keras, only tf.tensordot (which can not treats SparseTensor) is called as this.

Do you have any plan to treat SparseTensor in tf.keras?

Will this change the current api? How?
We can fix it simply using tf.sparse_tensor_dense_matmul.
If needed, I can create PR.

@facaiy facaiy added the stat:awaiting tensorflower Status - Awaiting response from tensorflower label Nov 22, 2018
@ymodak
Copy link
Contributor

ymodak commented Jul 25, 2019

I believe we have this feature now in TF tf.sparse.sparse_dense_matmul. Please reopen if that's not the case. Thanks!

@ymodak ymodak closed this as completed Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat:awaiting tensorflower Status - Awaiting response from tensorflower
Projects
None yet
Development

No branches or pull requests

4 participants