Fix comparison between signed and unsigned integer expressions in ten… #23996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrry
suggested changes
Nov 27, 2018
Harshini-Gadige
added
the
stat:awaiting response
mrry
added
kokoro:force-run
|
@mrry - Can the following kokoro failures be bypassed in order to proceed to get this merged ? |
|
The clang-format errors need to be fixed first. The Ubuntu and Window GPU failures look like flakes. |
@Kh4L Could you run clang-format-3.6.0 on this? |
|
@Harshini-Gadige done |
@mrry Can you please check now and approve ? |
mrry
approved these changes
Dec 3, 2018
tensorflow-copybara
pushed a commit
that referenced
this pull request
Dec 3, 2018
PiperOrigin-RevId: 223824219
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sor_format.h