systemlibs: Unbundle protobuf #24004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angerson
previously approved these changes
Nov 28, 2018
There was a problem hiding this comment.
Knowing that this has been in Gentoo is very reassuring. Thanks for mentioning that.
I took a cursory look at the changes, but I'm not familiar with any of the protobuf code they modify, so I can't say much aside from "it's looks good as long as it works". It'll be nice to have in, especially considering it doesn't change the default behavior. @gunan, can you also take a look at this?
I'm assuming our automated internal linter will request some stylistic changes, just as a heads-up.
Use system_link_files for protobuf.bzl. The protobuf.bzl file is taken verbatim from the protobuf repo. This version of protobuf.bzl will only be used when opting into using the system version of protobuf and is off by default. Signed-off-by: Jason Zaman <jason@perfinion.com>
gunan
approved these changes
Dec 5, 2018
gunan
approved these changes
Dec 5, 2018
tensorflow-copybara
pushed a commit
that referenced
this pull request
Dec 5, 2018
PiperOrigin-RevId: 224213775
|
Cool, it got merged without any problems. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use system_link_files for protobuf.bzl. The protobuf.bzl file is taken
verbatim from the protobuf repo. This version of protobuf.bzl will only
be used when opting into using the system version of protobuf and is off
by default.
Signed-off-by: Jason Zaman jason@perfinion.com
I've had this patch in the Gentoo package for TF for the last several versions and not had any issues reported.
@gunan @angersson for review