-
Notifications
You must be signed in to change notification settings - Fork 74k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Dockerfile assembler system #24051
Upgrade Dockerfile assembler system #24051
Conversation
The full suite of versioned images are available at https://hub.docker.com/r/angersson/tensorflow/tags/, e.g.: docker run -it --rm --runtime=nvidia -u $(id -u):$(id -g) angersson/tensorflow:zeus-gpu bash |
This is a big upgrade to the Dockerfile assembler I wrote a couple of months ago. The spec has changed, the script has been rewritten, and there are new features throughout: - The assembler can build and upload images to Docker Hub. - The assembler can also run tests (!), although the testing system is extremely rudimentary. It could be expanded with parallelism later, if execution time becomes a problem. - spec.yml is totally different, and now defines both dockerfiles and images. It handles the combinatorial explosion of multiple optional features without excessive duplication, unlike the previous spec format. - Partials are the same, but I dumped the extensive dockerfile documentation support because I don't think anyone would have used it. - Dockerfiles are handled under the same kind of system as images, which is neat. The new Dockerfiles aren't so duplicated. - I've upgraded the images with new tensorflow tutorial files (jupyter only) and fixed some others that didn't actually work. - I've improved the development documentation by suggesting aliases. - Added "static-dockerfiles" directory to track independent Dockerfiles. These changes should better support changes like tensorflow#23194.
4d77702
to
675f415
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good. Some terminology and function names can be better, but apart from one no big objections.
Thanks for the review. I fixed the problems you noted, plus a few more small issues. |
PiperOrigin-RevId: 223601056
I created a singularity image using this command:
But when I launch this script:
it gives me this error:
|
@maystroh Are you using the nvidia-docker2 runtime to launch the GPU images? I don't know how singularity works, but that looks like the same kind of failure that occurs when you don't use |
It works when I add --nv to my singularity command. Thanks @angersson |
This is a big upgrade to the Dockerfile assembler I wrote a couple of
months ago. The spec has changed, the script has been rewritten, and
there are new features throughout:
extremely rudimentary. It could be expanded with parallelism later, if
execution time becomes a problem.
images. It handles the combinatorial explosion of multiple optional features
without excessive duplication, unlike the previous spec format.
documentation support because I don't think anyone would have used it.
is neat. The new Dockerfiles aren't so duplicated.
only) and fixed some others that didn't actually work.
These changes should better support changes like #23194.