#21745: set timeout for closing worker session #24193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Transferring this PR to @saeta, since it affects things he is interested in, and I'm not going to have time to look at it. |
saeta
approved these changes
Dec 10, 2018
ymodak
added
ready to pull
pull bot
pushed a commit
to Rachelmorrell/tensorflow
that referenced
this pull request
Dec 10, 2018
PiperOrigin-RevId: 224853946
tensorflow-copybara
pushed a commit
that referenced
this pull request
Dec 20, 2018
|
@saeta +1, why this patch is reverted? |
|
The patch was causing segfaults, I think because of a use-after-free bug: the callbacks would still be called after the function returned, accessing the stack-allocated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#21745: set timeout for closing worker session