[OpenMP] Fix undeclared identifier in eigen_support.cc #24402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When OpenMP is enabled, the following error occurs during a compilation of the `tensorflow/lite/kernels/eigen_support.cc` unit: tensorflow/lite/kernels/eigen_support.cc:42:23: error: use of undeclared identifier 'context' Eigen::setNbThreads(context->recommended_num_threads); The `SetEigenNbThreads` method already gets the number of threads as the `threads` parameter and doesn't need to calculate it using a method of the `context` variable, so the invocation of the `Eigen::setNbThreads` member must be changed a little bit. Signed-off-by: Pavel Samolysov <samolisov@gmail.com>
|
Nagging Reviewer @jdduke: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 14 days with no activity and the |
jdduke
approved these changes
Jan 7, 2019
ymodak
added
kokoro:force-run
tensorflow-copybara
pushed a commit
that referenced
this pull request
Jan 17, 2019
…en-mp PiperOrigin-RevId: 229806616
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When OpenMP is enabled, the following error occurs during a
compilation of the
tensorflow/lite/kernels/eigen_support.ccunit:tensorflow/lite/kernels/eigen_support.cc:42:23: error: use of undeclared
identifier 'context'
Eigen::setNbThreads(context->recommended_num_threads);
The
SetEigenNbThreadsmethod already gets the number of threads as thethreadsparameter and doesn't need to calculate it using a method ofthe
contextvariable, so the invocation of theEigen::setNbThreadsmember must be changed a little bit.
Signed-off-by: Pavel Samolysov samolisov@gmail.com