Fix Windows build due to winsock2.h conflicts

[rongjiecomputer]

Some abseil header files include windows.h. Without WIN32_LEAN_AND_MEAN macro, windows.h will include winsock.h which will conflict with other files that want to include winsock2.h instead.

We should be able to revert these rollbacks after this PR.

• d08271d
• eeaca34

[rongjiecomputer]

@perfinion Can you help me to trigger CI test so that I can check if this does fix Windows CI?

[perfinion]

@rongjiecomputer Just to be clear, do you want experimental_shortened_obj_file_path added or removed? If you want it removed, can you squash both your commits into one and rebase it on top of master once 25335 is merged into master? That will be much cleaner and less error-prone than the second commit which adds it back.

[rongjiecomputer]

If you want it removed, can you squash both your commits into one and rebase it on top of master once 25335 is merged into master? That will be much cleaner and less error-prone than the second commit which adds it back.

Done.

[angerson]

I'll approve this once @perfinion has approved it, if needed.

[perfinion]

looks good!

[meteorcloudy]

Adding build --copt=-DWIN32_LEAN_AND_MEAN --host_copt=-DWIN32_LEAN_AND_MEAN into bazelrc file will cause the whole TensorFlow build not being able to use some of the less frequently used APIs. Can we only add --copt=-DWIN32_LEAN_AND_MEAN --host_copt=-DWIN32_LEAN_AND_MEAN to the targets that actually need it?

FYI @gunan , this caused the failure

Execution platform: @org_tensorflow//third_party/toolchains/preconfig/win_1803:rbe_windows_1803
external/bazel_tools/src/main/cpp/util/file_windows.cc(526): error C2065: 'FSCTL_GET_REPARSE_POINT': undeclared identifier
external/bazel_tools/src/main/cpp/util/file_windows.cc(615): error C2065: 'FSCTL_GET_REPARSE_POINT': undeclared identifier

[rongjiecomputer]

@meteorcloudy I don't think it is easy to figure out which files that need WIN32_LEAN_AND_MEAN. Having to add copts for the affected targets is also pretty tedious in Bazel.

A workaround is for files that need header filtered by WIN32_LEAN_AND_MEAN, explicitly include them instead of relying on windows.h to include them.

Here is a test:

#define WIN32_LEAN_AND_MEAN
#include <windows.h>
#include <WinIoCtl.h>

#ifndef FSCTL_GET_REPARSE_POINT
#error "Hello"
#else
#error "World"
#endif`

FSCTL_GET_REPARSE_POINT comes from WinIoCtl.h (https://msdn.microsoft.com/en-us/library/windows/desktop/aa364571(v=vs.85).aspx).

[meteorcloudy]

@rongjiecomputer Thank you!