Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Tensorflow version that detects CPU instruction set at runtime and lights-up/down #25590

Open
ericstj opened this issue Feb 7, 2019 · 7 comments
Assignees
Labels
type:build/install Build and install issues type:feature Feature requests

Comments

@ericstj
Copy link

ericstj commented Feb 7, 2019

System information

  • TensorFlow version (you are using): 1.12.0 CPU

Describe the feature and the current behavior/state.
Currently Tensorflow cross-compiles for different instruction sets and will warn if the CPU supports instructions that the TF build does not use, and fail to load if the CPU does not support an instruction set that the TF build uses. This makes it impossible to build an application that runs on a variety of hardware and ensure that it achieves optimal results for that hardware (or even runs at all).

I understand that TF supports cross-compilation and developers can build their own library that works best for their hardware, but this doesn't solve the case where an application developer wants to ship an application that uses TF and runs on a variety of hardware.

I understand that having multiple codepaths with runtime light-up could increase the size of TF, that could be dealt with by making this a separate flavor/configuration of TF, eg: "portable" build, and that could be published as a binary zip/tarball along side the current builds.

Will this change the current api? How?
No

Who will benefit with this feature?
Applications and libraries redistributing tensor flow binaries to run on a variety of hardware.

@gunan
Copy link
Contributor

gunan commented May 10, 2019

Maybe using MKL can help with this.
https://github.com/tensorflow/community/blob/master/rfcs/20180604-dynamic-kernels.md will definitely be able to help.
I am hoping to be able to land dynamic kernels this quarter.

@gunan gunan removed their assignment Sep 28, 2020
@rmothukuru rmothukuru self-assigned this Jun 16, 2021
@rmothukuru rmothukuru added the stat:awaiting response Status - Awaiting response from author label Jun 16, 2021
@rmothukuru
Copy link
Contributor

@ericstj,
RFC mentioned in this comment has been accepted and the support for MKL is specified in Tensorflow Documentation. Can you please let us know if the feature you are looking for is implemented? Thanks!

@ericstj
Copy link
Author

ericstj commented Jun 17, 2021

Is this flavor of TensorFlow produced and published as part of regular releases? If you have a link to the binaries we could take a look.

That would enable projects like https://github.com/SciSharp/TensorFlow.NET (used by https://github.com/dotnet/machinelearning) to redistribute these. cc @Oceania2018 @michaelgsharp

@google-ml-butler
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you.

@google-ml-butler google-ml-butler bot added the stale This label marks the issue/pr stale - to be closed automatically if no activity label Jun 24, 2021
@ericstj
Copy link
Author

ericstj commented Jun 24, 2021

I responded, and asked a question. I don't believe this should be stalled.

@google-ml-butler google-ml-butler bot removed stale This label marks the issue/pr stale - to be closed automatically if no activity stat:awaiting response Status - Awaiting response from author labels Jun 24, 2021
@rmothukuru rmothukuru removed their assignment Jun 25, 2021
@SuryanarayanaY
Copy link
Collaborator

Hi @ericstj ,

I am going through the backlogs and observed this issue can be clarified to you or may be you might have already known this. Right now 'mkl' builds are not part of TF official binaries. But it is available as preconfigured configuration using bazel build.Users need to build from source using --config=mkl option using bazel.You can refer the documentation here.

@SuryanarayanaY SuryanarayanaY self-assigned this Nov 23, 2023
@SuryanarayanaY SuryanarayanaY added the stat:awaiting response Status - Awaiting response from author label Nov 23, 2023
@ericstj
Copy link
Author

ericstj commented Nov 27, 2023

I understand it's not built by default. This issue was a request that it be added to the set of official binaries so that users might benefit from it without having to build it themselves.

@google-ml-butler google-ml-butler bot removed the stat:awaiting response Status - Awaiting response from author label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:build/install Build and install issues type:feature Feature requests
Projects
None yet
Development

No branches or pull requests

5 participants