-
Notifications
You must be signed in to change notification settings - Fork 74k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gpu_fusible.h #25741
Merged
Merged
Update gpu_fusible.h #25741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conumser -> consumer
Harshini-Gadige
previously approved these changes
Feb 14, 2019
pragyaak
added
kokoro:force-run
Tests on submitted change
and removed
awaiting review
Pull request awaiting review
labels
Feb 14, 2019
d0k
requested changes
Feb 16, 2019
@@ -48,7 +48,7 @@ bool IsInputFusibleReduction(const HloInstruction& instr); | |||
|
|||
// Whether instruction shapes are compatible for multi-output fusion, i.e. | |||
// whether the emitters support lowering the resulting fusion. | |||
// This function works for both, sibling and producer-conumser multi-output | |||
// This function works for both, sibling and producer-consumser multi-output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consumser
is still a typo ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@d0k thanks.
d0k
approved these changes
Feb 16, 2019
tensorflow-copybara
pushed a commit
that referenced
this pull request
Feb 18, 2019
PiperOrigin-RevId: 234440660
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
conumser -> consumer