Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename atrous_conv2d to dilated_conv2d? #2588

Closed
ry opened this issue May 30, 2016 · 7 comments
Closed

Rename atrous_conv2d to dilated_conv2d? #2588

ry opened this issue May 30, 2016 · 7 comments

Comments

@ry
Copy link
Contributor

ry commented May 30, 2016

The name comes from French "à trous" so it seems there should be an extra underscore in there at least... but this is still unintelligible to non-french speakers. Better would be to use the English word 'dilated'.

@ry ry changed the title Rename atros_conv2d to dialated_conv2d? Rename atrous_conv2d to dialated_conv2d? May 30, 2016
@vrv
Copy link

vrv commented May 31, 2016

Seems reasonable to add another alias so that dialated_conv2d == atrous_conv2d. You can add the alias into nn_ops.py like we do for other kinds of renames here: https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/ops/math_ops.py#L1212

@ry
Copy link
Contributor Author

ry commented May 31, 2016

May I make dilated_conv2d the default name (particularly in the documentation) and leave atrous_conv2d as the alias?

@vrv
Copy link

vrv commented May 31, 2016

@gpapan what do you think?

@tobin
Copy link

tobin commented Jun 1, 2016

Surprisingly, the correct spelling seems to be "dilated".

@aselle aselle added the triaged label Jun 1, 2016
@ry ry changed the title Rename atrous_conv2d to dialated_conv2d? Rename atrous_conv2d to dilated_conv2d? Jun 1, 2016
@ry
Copy link
Contributor Author

ry commented Jun 1, 2016

@tobin oops, thanks

@gpapan
Copy link

gpapan commented Jun 2, 2016

@ry I prefer atrous_conv2d.

I will reserve the name dilation for the morphological operation https://en.wikipedia.org/wiki/Dilation_(morphology) which will be added very soon to TF.

We used the term "atrous convolution" in the CVPR 2015 paper:
http://www.cv-foundation.org/openaccess/content_cvpr_2015/html/Papandreou_Modeling_Local_and_2015_CVPR_paper.html
before the term "dilated convolution" was proposed in https://arxiv.org/abs/1511.07122.

@ry
Copy link
Contributor Author

ry commented Jun 2, 2016

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants