Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TFTRT: Allow ops to specify their supported datatypes #25951

Merged

Conversation

trevor-m
Copy link
Contributor

AllowDataTypes() is a helper function to allow each converter to specify which datatypes are supported. Previously MatMul and BiasAdd had a similar check, but now every converter uses this new standard helper function.

Other minor enhancement included in this PR:

  • Use CreateBroadcastableScalarConstant for ConvertSquare
  • Remove redundant input check in ConvertTopK
  • Use CheckInputsWeights for ConvertLeakyRelu

@rthadur rthadur added the size:M CL Change Size: Medium label Feb 21, 2019
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Feb 21, 2019
@rthadur rthadur self-assigned this Feb 21, 2019
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Mar 2, 2019
@aaroey aaroey added ready to pull PR ready for merge process kokoro:force-run Tests on submitted change labels Mar 2, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 2, 2019
@tensorflow-copybara tensorflow-copybara merged commit 23d91f7 into tensorflow:master Mar 3, 2019
PR Queue automation moved this from Approved by Reviewer to Merged Mar 3, 2019
tensorflow-copybara pushed a commit that referenced this pull request Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes ready to pull PR ready for merge process size:M CL Change Size: Medium
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

7 participants