Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace add_variable() with add_weight() #26358

Merged
merged 1 commit into from Mar 11, 2019
Merged

Replace add_variable() with add_weight() #26358

merged 1 commit into from Mar 11, 2019

Conversation

amitsrivastava78
Copy link
Contributor

Changes in the rnn_cell.py file

Replace add_variable() with add_weight()
3d7e589 
Changes in the rnn_cell.py file
@rthadur rthadur self-assigned this Mar 5, 2019
@rthadur rthadur requested a review from jdduke March 5, 2019 18:56
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Mar 5, 2019
@rthadur rthadur added awaiting review Pull request awaiting review size:XS CL Change Size: Extra Small labels Mar 5, 2019
@jdduke
Copy link
Member

jdduke commented Mar 8, 2019

Please add more context to the description. Why is this replacement being done?

@amitsrivastava78
Copy link
Contributor Author

@jdduke the add_variable method here ends up calling add_weight. Kindly see the below link.

tensorflow/tensorflow/python/keras/_impl/keras/engine/base_layer.py

Line 438 in 4ca24c6

return self.add_weight(*args, **kwargs)

@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label Mar 9, 2019
@jdduke jdduke requested review from renjie-liu and removed request for jdduke March 11, 2019 16:59
@jdduke
Copy link
Member

jdduke commented Mar 11, 2019

I see, over to Renjie for further review.

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Mar 11, 2019
@rthadur rthadur added ready to pull PR ready for merge process kokoro:force-run Tests on submitted change labels Mar 11, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 11, 2019
@tensorflow-copybara tensorflow-copybara merged commit 3d7e589 into tensorflow:master Mar 11, 2019
PR Queue automation moved this from Approved by Reviewer to Merged Mar 11, 2019
tensorflow-copybara pushed a commit that referenced this pull request Mar 11, 2019
@tensorflower-gardener
Merge pull request #26358 from amitsrivastava78:rnn_cell
09f1040 
PiperOrigin-RevId: 237864863
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renjie-liu renjie-liu renjie-liu approved these changes

Assignees

@rthadur rthadur

Labels
cla: yes ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@amitsrivastava78 @jdduke @renjie-liu @googlebot @kokoro-team @tensorflowbutler @tensorflow-copybara @rthadur