Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROCm] Enable ROCm support for "softsign_op" #26583

Merged
merged 1 commit into from Apr 24, 2019
Merged

[ROCm] Enable ROCm support for "softsign_op" #26583

merged 1 commit into from Apr 24, 2019

Conversation

deven-amd
Copy link
Contributor

@deven-amd deven-amd commented Mar 11, 2019 •
edited

This PR enables ROCm support for the "softsign_op".

PR #26457 is a pre-req for this PR, and hence this PR includes commits from that PR.
Only the last commit in this PR should be reviewed here (as all others will be reviewed as part of PR #26457 )

The change for this PR is rather trivial :)

@tatianashp @whchung : just FYI.

@rthadur rthadur requested a review from timshen91 March 11, 2019 21:57
@rthadur rthadur self-assigned this Mar 11, 2019
@rthadur rthadur added awaiting review Pull request awaiting review size:M CL Change Size: Medium labels Mar 11, 2019
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Mar 11, 2019
@rthadur rthadur requested review from aaroey and removed request for timshen91 March 13, 2019 22:17
@aaroey
Copy link
Member

aaroey commented Mar 13, 2019

Hi @rthadur, I'm not familiar with this, would you help to find someone else?
Thanks.

@rthadur
Copy link
Contributor

rthadur commented Mar 13, 2019

Hi @rthadur, I'm not familiar with this, would you help to find someone else?
Thanks.
Sure

@rthadur rthadur requested review from skye and removed request for aaroey March 13, 2019 22:28
@skye skye requested review from whchung and tatianashp and removed request for skye March 13, 2019 23:20
@whchung
Copy link
Contributor

whchung commented Mar 13, 2019

@tatianashp please advise the next step ASAP. I don’t think I have permission to approve this PR as I’m part of the contributor, but it seems no one at google would like to review this PR?

@aaroey
Copy link
Member

aaroey commented Mar 14, 2019

Also @chsigg

@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label Mar 14, 2019
@deven-amd
Copy link
Contributor Author

@chsigg

rebased this PR, since PR #26457 has been merged...now this PR is truly trivial :)

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Mar 14, 2019
whchung
whchung previously approved these changes Mar 14, 2019
View reviewed changes
Copy link
Contributor

@whchung whchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of course I'll give a thumb up to this PR. now I wish I have the authority to merge it...

@whchung whchung added the kokoro:force-run Tests on submitted change label Mar 14, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 14, 2019
@thirupalanisamy thirupalanisamy assigned chsigg and unassigned rthadur Mar 14, 2019
PR Queue automation moved this from Approved by Reviewer to Reviewer Requested Changes Mar 18, 2019
@deven-amd
Copy link
Contributor Author

rebased to remove merge conflicts

@deven-amd
Copy link
Contributor Author

@chsigg , this PR should be good to go...please approve. thanks.

PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Apr 24, 2019
@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Apr 24, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Apr 24, 2019
@tensorflow-copybara tensorflow-copybara merged commit 900464e into tensorflow:master Apr 24, 2019
PR Queue automation moved this from Approved by Reviewer to Merged Apr 24, 2019
tensorflow-copybara pushed a commit that referenced this pull request Apr 24, 2019
@tensorflower-gardener
Merge pull request #26583 from ROCmSoftwarePlatform:google_upstream_s…
44ec36c 
…oftsign_op

PiperOrigin-RevId: 245116560
@deven-amd deven-amd deleted the google_upstream_softsign_op branch May 6, 2019 13:59
@deven-amd deven-amd restored the google_upstream_softsign_op branch May 6, 2019 13:59
@deven-amd deven-amd deleted the google_upstream_softsign_op branch May 6, 2019 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chsigg chsigg chsigg approved these changes

@whchung whchung whchung left review comments

@tatianashp tatianashp Awaiting requested review from tatianashp

Assignees

@chsigg chsigg

Labels
cla: yes ready to pull PR ready for merge process size:M CL Change Size: Medium
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@deven-amd @aaroey @rthadur @whchung @chsigg @googlebot @kokoro-team @tensorflowbutler @tensorflow-copybara