[ROCm] Enable ROCm support for the "staging" op #26702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rthadur
added
awaiting review
|
I would not be a good reviewer for this PR, please reassign. |
deven-amd
force-pushed
the
google_upstream_stage_op
branch
from
b7b260c
to
9d1cb2f
Compare
|
rebased this PR since PR #26457 has now been merged |
|
a much smaller PR indeed |
|
The PR looks good to me, but I don't maintain TF ops. Adding @chsigg . |
chsigg
approved these changes
Mar 15, 2019
chsigg
added
ready to pull
tensorflow-copybara
pushed a commit
that referenced
this pull request
Mar 15, 2019
…tage_op PiperOrigin-RevId: 238681135
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables ROCm support for the "staging" ops.
PR #26457 is a pre-req for this PR, and hence this PR includes commits from that PR.
Only the last commit in this PR (the one which updates the
tensorflow/core/kernels/stage_op.ccfile) should be reviewed here (as all others will be reviewed as part of PR #26457 )@tatianashp @whchung : just FYI.