Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provides example for tf.argsort and tf.sort #26822

Merged
merged 2 commits into from Apr 5, 2019
Merged

Provides example for tf.argsort and tf.sort #26822

merged 2 commits into from Apr 5, 2019

Conversation

Ayush517
Copy link
Contributor

Fixes issue #26533

mandroid6
mandroid6 suggested changes Mar 18, 2019
View reviewed changes
Copy link
Contributor

@mandroid6 mandroid6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stick to 'Usage:', remove 'For example:'.

@Ayush517 Ayush517 changed the title Provide example for tf.argsort Provides example for tf.argsort and tf.sort Mar 18, 2019
mandroid6
mandroid6 suggested changes Mar 18, 2019
View reviewed changes
Copy link
Contributor

@mandroid6 mandroid6 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works now

@Ayush517
Copy link
Contributor Author

So, any more changes or it's good now?

@rthadur rthadur added the comp:ops OPs related issues label Mar 18, 2019
@rthadur rthadur self-assigned this Mar 18, 2019
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Mar 18, 2019
@rthadur rthadur added awaiting review Pull request awaiting review size:S CL Change Size: Small labels Mar 18, 2019
@tensorflowbutler
Copy link
Member

Nagging Reviewer : You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 15 days with no activity and the awaiting review label has been applied.

@rthadur rthadur requested review from alextp and suharshs April 5, 2019 21:12
alextp
alextp approved these changes Apr 5, 2019
View reviewed changes
Copy link
Contributor

@alextp alextp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

(optional) Can you also add these examples as unit tests in tensorflow/python/ops/sort_ops_test.py ?

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Apr 5, 2019
@alextp alextp added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process and removed awaiting review Pull request awaiting review labels Apr 5, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Apr 5, 2019
@tensorflow-copybara tensorflow-copybara merged commit 937a02a into tensorflow:master Apr 5, 2019
PR Queue automation moved this from Approved by Reviewer to Merged Apr 5, 2019
tensorflow-copybara pushed a commit that referenced this pull request Apr 5, 2019
@tensorflower-gardener
Merge pull request #26822 from Ayush517:patch-2
342f4d3 
PiperOrigin-RevId: 242208793
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextp alextp alextp approved these changes

@mandroid6 mandroid6 mandroid6 approved these changes

@kyscg kyscg kyscg approved these changes

@suharshs suharshs Awaiting requested review from suharshs

Assignees

@rthadur rthadur

Labels
cla: yes comp:ops OPs related issues ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@Ayush517 @tensorflowbutler @alextp @mandroid6 @kyscg @googlebot @kokoro-team @tensorflow-copybara @rthadur