Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lite: Slice Op refactored #26936

Merged
merged 5 commits into from
Jul 9, 2020
Merged

Lite: Slice Op refactored #26936

merged 5 commits into from
Jul 9, 2020

Conversation

ANSHUMAN87
Copy link
Contributor

@ANSHUMAN87 ANSHUMAN87 commented Mar 20, 2019 •
edited

Remove unnecessary reversal of input dimension

@rthadur rthadur self-assigned this Mar 20, 2019
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Mar 20, 2019
@rthadur rthadur added comp:lite TF Lite related issues size:S CL Change Size: Small labels Mar 20, 2019
@karimnosseir karimnosseir requested review from jianlijianli and removed request for karimnosseir March 25, 2019 14:48
@ANSHUMAN87
Copy link
Contributor Author

@jianlijianli : Gentle Reminder!

@ANSHUMAN87
Copy link
Contributor Author

@jianlijianli : Gentle Reminder!

2 similar comments
@ANSHUMAN87
Copy link
Contributor Author

@jianlijianli : Gentle Reminder!

@ANSHUMAN87
Copy link
Contributor Author

@jianlijianli : Gentle Reminder!

@rthadur rthadur added the awaiting review Pull request awaiting review label Jun 26, 2019
@mellanox-github
Copy link

Can one of the admins verify this patch?

@jianlijianli
Copy link
Contributor

Could you please add a high level description what this CL does? Thanks.

@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label Nov 21, 2019
@rthadur rthadur added the stat:awaiting response Status - Awaiting response from author label Nov 21, 2019
@gbaned
Copy link
Contributor

gbaned commented Nov 26, 2019

@ANSHUMAN87 Could you please address the reviewer comments and resolve conflicts? Thanks!

@tensorflowbutler tensorflowbutler added the stale This label marks the issue/pr stale - to be closed automatically if no activity label Dec 11, 2019
@ANSHUMAN87
Copy link
Contributor Author

Could you please add a high level description what this CL does? Thanks.

Updated!

@tensorflowbutler tensorflowbutler added stat:awaiting response Status - Awaiting response from author and removed stat:awaiting response Status - Awaiting response from author stale This label marks the issue/pr stale - to be closed automatically if no activity labels Dec 12, 2019
@gbaned gbaned requested review from jianlijianli and removed request for jianlijianli December 18, 2019 07:03
@gbaned gbaned added awaiting review Pull request awaiting review and removed stat:awaiting response Status - Awaiting response from author labels Dec 18, 2019
@ANSHUMAN87
Copy link
Contributor Author

@jianlijianli: Gentle reminder!

@rthadur rthadur removed the ready to pull PR ready for merge process label Jun 10, 2020
rthadur
rthadur previously approved these changes Jun 10, 2020
View reviewed changes
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jun 10, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jun 10, 2020
@rthadur
Copy link
Contributor

rthadur commented Jun 10, 2020

@ANSHUMAN87 getting below error , can you please check
/tensorflow/lite/kernels/test_util.cc:317 Expected equality of these values: CountPartitionsDelegatedTo(interpreter_.get(), TestNnApiDelegate()) Which is: 0 1 Expecting operation to be accelerated but cannot find a partition associated to the NNAPI delegate

@rthadur rthadur removed the ready to pull PR ready for merge process label Jun 10, 2020
@ANSHUMAN87
Copy link
Contributor Author

@ANSHUMAN87 getting below error , can you please check
/tensorflow/lite/kernels/test_util.cc:317 Expected equality of these values: CountPartitionsDelegatedTo(interpreter_.get(), TestNnApiDelegate()) Which is: 0 1 Expecting operation to be accelerated but cannot find a partition associated to the NNAPI delegate

@rthadur : Sorry for late response! The error you posted does not seem to be relevant to my change! Please let me know, if anything needs to be done from my end. Thanks!

@rthadur
Copy link
Contributor

rthadur commented Jun 17, 2020

@jianlijianli @jdduke can you please help with internal failures ?

PR Queue automation moved this from Approved by Reviewer to Reviewer Requested Changes Jun 17, 2020
@gbaned
Copy link
Contributor

gbaned commented Jul 3, 2020

@ANSHUMAN87 Can you please check @jdduke's comments and keep us posted. Thanks!

@gbaned gbaned added the stat:awaiting response Status - Awaiting response from author label Jul 3, 2020
@ANSHUMAN87
Copy link
Contributor Author

@gbaned : Thanks for tracking it! I have updated based on @jdduke comment for the internal failure reported by @rthadur .
Can you please approve it, and check for merge, as the new change is only to disable the test cases ? TIA!

@tensorflowbutler tensorflowbutler removed the stat:awaiting response Status - Awaiting response from author label Jul 5, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jul 6, 2020
@kokoro-team kokoro-team removed kokoro:force-run Tests on submitted change labels Jul 6, 2020
@tensorflow-copybara tensorflow-copybara merged commit cee3559 into tensorflow:master Jul 9, 2020
PR Queue automation moved this from Reviewer Requested Changes to Merged Jul 9, 2020
@ANSHUMAN87
Copy link
Contributor Author

Thanks @jdduke, @rthadur, @gbaned!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdduke jdduke jdduke requested changes

@rthadur rthadur rthadur approved these changes

@jianlijianli jianlijianli Awaiting requested review from jianlijianli

Assignees

@rthadur rthadur

Labels
cla: yes comp:lite TF Lite related issues ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@ANSHUMAN87 @mellanox-github @jianlijianli @gbaned @rthadur @jdduke @googlebot @kokoro-team @tensorflowbutler @tensorflow-copybara