Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing args in description for LSTM and GRU #27011

Merged
merged 1 commit into from Apr 5, 2019
Merged

Add missing args in description for LSTM and GRU #27011

merged 1 commit into from Apr 5, 2019

Conversation

donovanOng
Copy link
Contributor

Added time_major description for LSTM and GRU.

Added time_major description for LSTM and GRU.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@donovanOng
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@rthadur rthadur requested a review from fchollet March 22, 2019 04:25
@rthadur rthadur self-assigned this Mar 22, 2019
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Mar 22, 2019
@rthadur rthadur added comp:keras Keras related issues size:S CL Change Size: Small labels Mar 22, 2019
@gbaned gbaned requested a review from qlzh727 April 5, 2019 05:11
Copy link
Member

@qlzh727 qlzh727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Apr 5, 2019
@rthadur rthadur added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Apr 5, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Apr 5, 2019
@tensorflow-copybara tensorflow-copybara merged commit 4d965b5 into tensorflow:master Apr 5, 2019
PR Queue automation moved this from Approved by Reviewer to Merged Apr 5, 2019
tensorflow-copybara pushed a commit that referenced this pull request Apr 5, 2019
PiperOrigin-RevId: 242203913
@donovanOng donovanOng deleted the patch-1 branch April 10, 2019 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:keras Keras related issues ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

6 participants