Add deprecation notice to tf.contrib.libsvm #27224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@josh11b Could you PTAL and approve. |
josh11b
reviewed
Apr 25, 2019
|
|
||
|
|
||
| _libsvm_ops_so = loader.load_op_library( | ||
| resource_loader.get_path_to_datafile("_libsvm_ops.so")) | ||
|
|
||
|
|
||
| @deprecated( | ||
| '2019-03-27', |
There was a problem hiding this comment.
I think we don't use the date argument.
There was a problem hiding this comment.
The date argument changes the warning generated, I would omit it, it's generally not accurate.
josh11b
requested review from
josh11b and
martinwicke
and removed request for
josh11b
yongtang
requested review from
aaroey,
agarwal-ashish,
alextp,
allenlavoie,
annarev,
azaks2,
caisq,
chsigg,
ebrevdo,
fchollet,
frankchn,
ispirmustafa,
jhseu,
joel-shor,
jvdillon and
katsiapis
as code owners
yupbank
previously approved these changes
Apr 25, 2019
tensorflow-bot
bot
added
kokoro:force-run
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
ebrevdo
approved these changes
Apr 25, 2019
annarev
approved these changes
Apr 25, 2019
gbaned
added
ready to pull
pull bot
pushed a commit
to testkevinbonz/tensorflow
that referenced
this pull request
May 3, 2019
PiperOrigin-RevId: 246454080
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since tf.contrib has been deprecated and will be removed
in TF 2.0, it makes sense to add deprecation notice
so that users could be pointed to tensorflow-io
Signed-off-by: Yong Tang yong.tang.github@outlook.com